-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create Cip1854ExtendedAccountPublicKey core type #1346
feat: create Cip1854ExtendedAccountPublicKey core type #1346
Conversation
|
2f2af4b
to
5fa744c
Compare
packages/core/test/Cardano/types/Cip1854ExtendedAccountPublicKey.test.ts
Outdated
Show resolved
Hide resolved
packages/core/test/Cardano/types/Cip1854ExtendedAccountPublicKey.test.ts
Outdated
Show resolved
Hide resolved
packages/core/test/Cardano/types/Cip1854ExtendedAccountPublicKey.test.ts
Outdated
Show resolved
Hide resolved
packages/core/test/Cardano/types/Cip1854ExtendedAccountPublicKey.test.ts
Outdated
Show resolved
Hide resolved
packages/core/test/Cardano/types/Cip1854ExtendedAccountPublicKey.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @greatertomi 💪🏼
5fdbd2f
to
673fcc6
Compare
Context and Proposed Solution
Add a new
Cip1854ExtendedAccountPublicKey
type that encodes CIP 1854 extended public keys in bech32 following CIP 5 specification.